CROM-6916 Fix support for optional SFS runtime attributes #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshakir
commented
May 9, 2022
Comment on lines
64
to
93
| ("present optional memory", "Float? memory_gb", Map("memory" -> WomString("3 GB")), Option(MemorySize(3, MemoryUnit.GB)).valid), | ||
| ("missing optional memory", "Float? memory_gb", Map(), None.valid), |
There was a problem hiding this comment.
For the reviewers:
This Float? memory_gb declaration used to work but stopped at some point, along with a few other declarations listed in this test. The symptom is that on Cromwell 78 when defined as optional in the SFS backend the memory runtime attribute still needs to be defined for tasks or the workflow fails.
The Float? memory_gb declaration is both already:
- Mentioned here in the docs
- Verified on a lower level without using the wrapper
fromDeclarationsin this other test
kshakir
changed the title
kshakir
force-pushed
the
ks_sfs_opt_rt_attr
branch
from
e9b3515 to
4d90157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.